yuxiqian commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2607045316
After some bisect searching I believe changes in this PR will caused
PolarDBX related tests to fail frequently (FLINK-37191).
--
This is an automated message from the Apache Git Serv
leonardBang merged PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink
github-actions[bot] commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2584936582
This pull request has been automatically marked as stale because it has not
had recent activity for 60 days. It will be closed in 30 days if no further
activity occurs.
--
ruanhang1993 commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2404520755
@lvyanquan Do you have time to help to review this PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
JNSimba commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2379575904
I changed this to compare timestamp in **BinlogOffset.compare** method, so
there is no need to set serverid, PTAL, thanks @ruanhang1993
--
This is an automated message from the Apach
JNSimba commented on code in PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778269742
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:
JNSimba commented on code in PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778269742
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:
JNSimba commented on code in PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778269742
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:
ruanhang1993 commented on code in PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778161501
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.j
JNSimba commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2363300595
Thanks, itcase has been added,PTAL @ruanhang1993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ruanhang1993 commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2359809213
@JNSimba Thanks for this PR. Please add some tests to cover the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2354238674
This pull request has been automatically marked as stale because it has not
had recent activity for 60 days. It will be closed in 30 days if no further
activity occurs.
--
JNSimba commented on PR #3415:
URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2235905175
@leonardBang @ruanhang1993 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
13 matches
Mail list logo
