Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-19 Thread via GitHub
dianfu merged PR #25541: URL: https://github.com/apache/flink/pull/25541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-18 Thread via GitHub
xaniasd commented on code in PR #25541: URL: https://github.com/apache/flink/pull/25541#discussion_r1921058918 ## flink-python/dev/dev-requirements.txt: ## @@ -15,7 +15,7 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam>=2.43.0,<2.49.0 +apache-beam>=2.54.0 Review Comment:

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-17 Thread via GitHub
xaniasd commented on code in PR #25541: URL: https://github.com/apache/flink/pull/25541#discussion_r1920511698 ## flink-python/dev/dev-requirements.txt: ## @@ -15,7 +15,7 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam>=2.43.0,<2.49.0 +apache-beam>=2.54.0 Review Comment:

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-14 Thread via GitHub
dianfu commented on code in PR #25541: URL: https://github.com/apache/flink/pull/25541#discussion_r1915824469 ## flink-python/dev/dev-requirements.txt: ## @@ -15,7 +15,7 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam>=2.43.0,<2.49.0 +apache-beam>=2.54.0 Review Comment:

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-14 Thread via GitHub
xaniasd commented on code in PR #25541: URL: https://github.com/apache/flink/pull/25541#discussion_r1914611858 ## flink-python/dev/dev-requirements.txt: ## @@ -15,7 +15,7 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam>=2.43.0,<2.49.0 +apache-beam>=2.54.0 Review Comment:

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-13 Thread via GitHub
dianfu commented on code in PR #25541: URL: https://github.com/apache/flink/pull/25541#discussion_r1913528026 ## flink-python/dev/dev-requirements.txt: ## @@ -15,7 +15,7 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam>=2.43.0,<2.49.0 +apache-beam>=2.54.0 Review Comment:

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-13 Thread via GitHub
xaniasd commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2587110193 removed @dianfu, thanks for clarifying. Perhaps we could add those api directories to .gitignore to avoid confusion in the future? -- This is an automated message from the Apache Git Se

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-13 Thread via GitHub
dianfu commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2586925519 @xaniasd These changes are not necessary. It will generate these files by default during generating the Python API website. Could you remove them from the PR? -- This is an automated me

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-13 Thread via GitHub
xaniasd commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2586662226 hi @dianfu I think these doc files were generated by sphinx while running `flink-python/dev/lint-python.sh` and I assume they reflect corresponding changes in the pyflink API. -- This

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-12 Thread via GitHub
dianfu commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2586123104 @xaniasd I see that it added a lot of doc files in this PR. Why we need to do this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2025-01-09 Thread via GitHub
dianfu commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2580337571 Sorry for late response. I will take a look at this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2024-12-27 Thread via GitHub
franciscojavierarceo commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2563974146 Any update on this? @dianfu @HuangXingBo @snuyanzin ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2024-11-21 Thread via GitHub
snuyanzin commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2490142517 @dianfu , @HuangXingBo could you please have a look here, I think you are more experienced with python in Flink -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2024-10-16 Thread via GitHub
flinkbot commented on PR #25541: URL: https://github.com/apache/flink/pull/25541#issuecomment-2417994708 ## CI report: * 81019ec9eaaae96e1873b1bc2a19efb56a52c32f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35282][python] Upgrade Apache Beam > 2.54 [flink]

2024-10-16 Thread via GitHub
xaniasd opened a new pull request, #25541: URL: https://github.com/apache/flink/pull/25541 ## What is the purpose of the change Based on #24908, upgrade Apache Beam dependency to >2.54. ## Brief change log Changes flink-python code and tests for compatibility with