1996fanrui merged PR #109:
URL: https://github.com/apache/flink-connector-jdbc/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
whhe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1700103068
##
flink-connector-jdbc-oceanbase/src/main/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactory.java:
##
@@ -54,6 +55,20 @@ public JdbcCata
whhe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1700044488
##
flink-connector-jdbc-oceanbase/src/main/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactory.java:
##
@@ -54,6 +55,20 @@ public JdbcCata
eskabetxe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1700016781
##
flink-connector-jdbc-oceanbase/src/main/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactory.java:
##
@@ -54,6 +55,20 @@ public Jdb
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2262117085
@eskabetxe PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2255336080
> @whhe can you rebase please, and move the related code to the new
OceanBase module. we just merge a part of
[FLIP-449](https://cwiki.apache.org/confluence/display/FLINK/FLIP-44
eskabetxe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2255329759
@whhe can you rebase please, and move the related code to the new OceanBase
module.
we just merge a part of
[FLIP-449](https://cwiki.apache.org/confluence/display/FLINK/F
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2228454081
@leonardBang @MartijnVisser @GOODBOY008 Can someone help with the review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
RocMarshal commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2216074991
@whhe nice work!
Could you help squish the commits into a single commit ? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2213542334
@RocMarshal Updated. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
whhe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1668082863
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseTypeMapper.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licens
whhe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1668077202
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java:
##
@@ -82,6 +84,14 @@ public static AbstractJdbcCatalog cr
RocMarshal commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1666475795
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseTypeMapper.java:
##
@@ -0,0 +1,167 @@
+/*
+ *
RocMarshal commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1666472631
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java:
##
@@ -82,6 +84,14 @@ public static AbstractJdbcCata
RocMarshal commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1666467123
##
docs/content/docs/connectors/table/jdbc.md:
##
@@ -654,6 +655,37 @@ SELECT * FROM crate.`custom_schema.test_table2`;
SELECT * FROM `custom_schema.tes
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2208676855
> Thanks @whhe for the contribution. Left a few of comments. PTAL ~
Thanks for your review, the documentations have been updated as suggested.
PTAL.
--
This is an automa
RocMarshal commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1665267264
##
docs/content.zh/docs/connectors/table/jdbc.md:
##
@@ -433,10 +433,9 @@ JDBC Catalog
`JdbcCatalog` 允许用户通过 JDBC 协议将 Flink 连接到关系数据库。
-目前，JDBC Catalo
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2205953828
> Hi, @whhe Thx for the contribution. Would you mind fixing the failed CI
action before the next review ?
Hi @RocMarshal, the CI failure is fixed now. PTAL
--
This is an
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2172572094
Anyone available? @eskabetxe @GOODBOY008 @leonardBang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2144456254
@eskabetxe PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2119061257
> I left some minor comments
Hi @eskabetxe, I updated these files, please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to th
eskabetxe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1605664750
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseOracleCatalogITCase.java:
##
@@ -0,0 +1,120 @@
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2112157138
@eskabetxe PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2027892325
@MartijnVisser PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
whhe commented on PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2020383288
Would you please take a look on this? @leonardBang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
whhe opened a new pull request, #109:
URL: https://github.com/apache/flink-connector-jdbc/pull/109
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
26 matches
Mail list logo
