Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2697453076 @hejufang Sure. Sorry for the late response. I'm busy preparing the Flink 2.0.0 release. It's on a pretty tight schedule and may take few more days. I'll check this after the release.

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-03-03 Thread via GitHub
hejufang commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2696066319 @Zakelly @masteryhx Could you please take a look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-02-13 Thread via GitHub
hejufang commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2658197651 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-02-11 Thread via GitHub
Zakelly commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2650102458 @hejufang Sorry for the late reply! I'd agree with you about current design. I'll take another look later (I'm in other things these days). And could you please rebase the ma

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-02-10 Thread via GitHub
hejufang commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2647472099 @Zakelly @masteryhx kindly remind -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-01-06 Thread via GitHub
hejufang commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2573083816 > Thanks for the PR! In general I have a question: why serializing the key/value by sampling, instead of read the serialization result/length of current put/add, especially for RocksDB?

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-01-02 Thread via GitHub
Zakelly commented on code in PR #25837: URL: https://github.com/apache/flink/pull/25837#discussion_r1901451065 ## flink-core/src/main/java/org/apache/flink/configuration/StateSizeTrackOptions.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2024-12-22 Thread via GitHub
flinkbot commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2558391257 ## CI report: * a0491f99a55587179dad4db2ead951a1b11b9b6d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34558][state] Support tracking state size [flink]

2024-12-22 Thread via GitHub
hejufang opened a new pull request, #25837: URL: https://github.com/apache/flink/pull/25837 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o