Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-02-15 Thread via GitHub
dawidwys merged PR #24203: URL: https://github.com/apache/flink/pull/24203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-02-15 Thread via GitHub
dawidwys commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1945896517 Thank you so much! It makes it so much easier to read it now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-02-14 Thread via GitHub
bvarghese1 commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1945216459 > Looks good, but could we make the input/output easier to digest? > > 1. Do we need to have a two column key? > 2. Can we have a non-numeric key? At least for me it's easier t

Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-01-26 Thread via GitHub
flinkbot commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1912908978 ## CI report: * 776ffbde30fa754b06a2858fa572800c5edd8ffa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-01-26 Thread via GitHub
bvarghese1 opened a new pull request, #24203: URL: https://github.com/apache/flink/pull/24203 ## What is the purpose of the change *Add restore tests for ChangelogNormalize node* ## Verifying this change This change added tests and can be verified as follows: -