twalthr merged PR #24886:
URL: https://github.com/apache/flink/pull/24886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1636579991
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##
@@ -1361,16 +1374,36 @@ public void tes
twalthr commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1636474722
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDistribution.java:
##
@@ -70,17 +70,28 @@ public List getOperandList() {
@Overri
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1628751202
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##
@@ -110,6 +113,7 @@ public Operation convertAlter
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1628750770
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##
@@ -916,15 +987,29 @@ private Operation buildAlte
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1628744001
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/SqlUnparseUtils.java:
##
@@ -40,7 +41,8 @@ public static void unparseTableSchema(
i
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1628741389
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##
@@ -339,6 +364,10 @@ private void populatePrimary
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1628741277
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##
@@ -206,6 +210,24 @@ public Operation convertAlte
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1628740059
##
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##
@@ -611,6 +611,70 @@ void testAlterTableAddWatermark() {
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1627941934
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##
@@ -916,15 +987,29 @@ private Operation buildAlte
twalthr commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1627848065
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/SqlUnparseUtils.java:
##
@@ -40,7 +41,8 @@ public static void unparseTableSchema(
flinkbot commented on PR #24886:
URL: https://github.com/apache/flink/pull/24886#issuecomment-2148475342
## CI report:
* 4081f6d00def12b386970d94681364dd99d089a6 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jnh5y opened a new pull request, #24886:
URL: https://github.com/apache/flink/pull/24886
## What is the purpose of the change
This PR implements the SQL parser changes for ALTER TABLE to support ADD,
MODIFY, and DROP DISTRIBUTION statements.
## Brief change log
The SQL Parse
13 matches
Mail list logo
