twalthr merged PR #23975:
URL: https://github.com/apache/flink/pull/23975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
AlanConfluent commented on PR #23975:
URL: https://github.com/apache/flink/pull/23975#issuecomment-1890773856
I have seen other PR jobs failing with identical python errors, so seems
unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the messa
AlanConfluent commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1451023480
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/ExtractionUtils.java:
##
@@ -348,6 +350,53 @@ public static Optional> extr
AlanConfluent commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1451023480
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/ExtractionUtils.java:
##
@@ -348,6 +350,53 @@ public static Optional> extr
AlanConfluent commented on PR #23975:
URL: https://github.com/apache/flink/pull/23975#issuecomment-1890159845
>The only issue currently is a green build. Is the error in the Python
related to your changes?
I'm pretty sure it's not. I can't make any sense of it at all anyhow. Will
r
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1450572179
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/table/AsyncCalcITCase.java:
##
@@ -0,0 +1,561 @@
+/*
+ * Licensed to the
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1450566541
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSplitRuleTest.java:
##
@@ -0,0 +1,274 @@
+/*
+ * Licensed to
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1450552569
##
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSplitRuleTest.xml:
##
@@ -0,0 +1,536 @@
+
+
+
+
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1450552569
##
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSplitRuleTest.xml:
##
@@ -0,0 +1,536 @@
+
+
+
+
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1449149984
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/AsyncUtil.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1449138779
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecAsyncCalc.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed t
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1449134322
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionMappingExtractor.java:
##
@@ -208,6 +249,32 @@ static MethodVerification
twalthr commented on code in PR #23975:
URL: https://github.com/apache/flink/pull/23975#discussion_r1449130065
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java:
##
@@ -67,6 +67,8 @@ public final class UserDefinedFunc
AlanConfluent commented on PR #23975:
URL: https://github.com/apache/flink/pull/23975#issuecomment-1884054834
I pushed my commit which adds more to the ability to resolve types in this
manner. I haven't yet had a chance to see all of the cases ScalarFunction
works or doesn't, but this is p
AlanConfluent commented on PR #23975:
URL: https://github.com/apache/flink/pull/23975#issuecomment-1883987246
I did notice that if you have some fairly complex generic hierarchy:
```
public abstract static class AsyncFuncGeneric extends AsyncFuncBase {
private static
AlanConfluent commented on PR #23975:
URL: https://github.com/apache/flink/pull/23975#issuecomment-1882073976
@twalthr Thanks Timo for the in-depth review! I think I was able to respond
to everything you mentioned, no real straggling issues. Please take another
look.
--
This is an auto
16 matches
Mail list logo
