libenchao closed pull request #23984: [FLINK-33792] Generate the same code for
the same logic
URL: https://github.com/apache/flink/pull/23984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1888360571
@lsyldliu I have updated my code, please have a took when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1888301428
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1886966518
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1886953624
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
lsyldliu commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1448202301
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/LongHashJoinGenerator.scala:
##
@@ -87,10 +90,11 @@ object LongHashJoinGenerat
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1884085496
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1882900226
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1882729028
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1882328998
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1445558740
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/LongHashJoinGenerator.scala:
##
@@ -87,10 +90,11 @@ object LongHashJoinGenerator
lsyldliu commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1444597660
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRule.java:
##
@@ -88,7 +91,16 @@ public ZoneId getSessionZoneId()
lsyldliu commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1444586092
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##
@@ -124,14 +124,27 @@ object CodeGenUtils {
privat
zoudan commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1440008761
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##
@@ -124,14 +124,27 @@ object CodeGenUtils {
private
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1874770437
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
libenchao commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1439438203
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##
@@ -124,14 +124,27 @@ object CodeGenUtils {
priva
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1873932825
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1439369220
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##
@@ -124,14 +124,27 @@ object CodeGenUtils {
private
libenchao commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1439188114
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##
@@ -124,14 +124,27 @@ object CodeGenUtils {
priva
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1871831781
@libenchao CI is passed, please take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1871674246
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1870974216
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
libenchao commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1868890131
@zoudan The PR looks good to me, except that the CI is failing, could you
fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
zoudan commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1868679111
@libenchao Thanks for reviewing, I have remove the configuration, please
take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the me
libenchao commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1434845148
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##
@@ -233,6 +233,16 @@ private TableConfigOptions() {}
flinkbot commented on PR #23984:
URL: https://github.com/apache/flink/pull/23984#issuecomment-1867349736
## CI report:
* d996c020cea9582b5df989f4eb277efb395931fb UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
zoudan opened a new pull request, #23984:
URL: https://github.com/apache/flink/pull/23984
## What is the purpose of the change
This pull request ensure that we generate the same code for the same logic,
it is a precondition for sharing generated classes between different jobs.
27 matches
Mail list logo
