Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-30 Thread via GitHub
dawidwys merged PR #23829: URL: https://github.com/apache/flink/pull/23829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1410385087 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-30 Thread via GitHub
twalthr commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1410380412 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
dawidwys commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1409609082 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
dawidwys commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1409580486 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
dawidwys commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1409579746 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
dawidwys commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1409557615 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java: ## @@ -219,6 +222,83 @@ public String asSummaryString()

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
twalthr commented on code in PR #23829: URL: https://github.com/apache/flink/pull/23829#discussion_r1409397810 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/expressions/LiteralExpressionsSerialisationITCase.java: ## @@ -0,0 +1,139 @@ +/* + * Lic

Re: [PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
flinkbot commented on PR #23829: URL: https://github.com/apache/flink/pull/23829#issuecomment-1831885299 ## CI report: * 581713f59027494d4c9dcabc4b5383db946b1e6b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33675] Serialize ValueLiteralExpressions into SQL [flink]

2023-11-29 Thread via GitHub
dawidwys opened a new pull request, #23829: URL: https://github.com/apache/flink/pull/23829 ## What is the purpose of the change This makes Expressions literals serialisable into SQL. ## Verifying this change Added a test for all literals in `LiteralExpressionsSeriali