Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-08 Thread via GitHub
fredia merged PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-08 Thread via GitHub
fredia commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349674528 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar with

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
Zakelly commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349620289 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar wit

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
Zakelly commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349620289 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar wit

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
fredia commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349611595 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar with

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-06 Thread via GitHub
Zakelly commented on PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#issuecomment-1751624381 I'm not sure if I have the right person, @pnowojski , but would you please review this one? -- This is an automated message from the Apache Git Service. To respond to the message,