ferenc-csaky merged PR #22789:
URL: https://github.com/apache/flink/pull/22789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2306422467
@ferenc-csaky @Jiabao-Sun Thank you two for your helpful review. If there
are any more tickets related to the JUnit 5 migration, I can help with I am
happy to take one over.
--
This
Jiabao-Sun commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1724163849
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSChecksumWriteChannelTest.java:
##
@@ -124,7 +126,7 @@ public void before() thro
ferenc-csaky commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2305290233
> @ferenc-csaky Shall I squash the commits, or will you do that when it gets
merged?
Squash and merge takes care of that, so it is not necessary I would say.
--
This is an a
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2305234180
@ferenc-csaky Shall I squash the commits, or will you do that when it gets
merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2304554860
Thanks for the feedback!
@Jiabao-Sun Not sure why the CI failed, this seems to be about timeouts in
tests, the changes in the last commit where mostly about reducing method
visibi
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r172533
##
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureBlobRecoverableWriterTest.java:
##
@@ -46,8 +45,13 @@ class AzureBlobReco
Jiabao-Sun commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1724162979
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableWriterCommitterTest.java:
##
@@ -122,7 +121,7 @@ public void before(
Jiabao-Sun commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1722593053
##
flink-filesystems/flink-oss-fs-hadoop/src/test/java/org/apache/flink/fs/osshadoop/HadoopOSSRecoverableWriterExceptionITCase.java:
##
@@ -36,14 +36,14 @@
* Tests
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2298457881
I tracked a missing test case down to HadoopS3FileSystemBehaviorITCase this
test doesn't run on my branch, but does run on the master branch. But this
wasn't modified in my PR, do you kn
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2298338218
@Jiabao-Sun Thanks for your review, I addressed your comments in the last
commit, for the more general things you mentioned I searched in
flink-filesystem for other occurrence of the sam
kottmann commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1722888913
##
flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemITCase.java:
##
@@ -48,20 +44,12 @@
*
href="https://docs.aws.am
Jiabao-Sun commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1722574780
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/GSFileSystemScenarioTest.java:
##
@@ -148,31 +147,31 @@ public void simpleWriteTest() th
Jiabao-Sun commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1722571689
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/GSFileSystemFactoryTest.java:
##
@@ -22,10 +22,10 @@
import org.junit.jupiter.api.Tes
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1722088247
##
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriterTest.java:
##
@@ -49,12 +48,14 @@ class HadoopRecoverabl
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2296533731
Thanks, I rebased it onto master and it should be possible to merge now.
Some classes received a bit of JUnit 5 migration from another commit before,
and I resolved those conflicts or re
kottmann commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1721750114
##
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriterTest.java:
##
@@ -49,12 +48,14 @@ class HadoopRecoverableWri
Jiabao-Sun commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2292582386
Thanks @kottmann for this contribution and @ferenc-csaky for the review,
Sorry for missing the message earlier.
Could you rebase master and resolve the conflicts?
--
This
ferenc-csaky commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2292116465
@kottmann I was not a committer back then, but if you will have some time
and desire to resolve the current conflicts, I still believe this would be a
nice improvement and will add i
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2085392466
@ferenc-csaky Thank you for reviewing my PR and for your helpful feedback! I
really appreciate your support in improving it.
--
This is an automated message from the Apache Git Service
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2084837876
This is fixed now as well, see new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1581270742
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableFsDataOutputStreamTest.java:
##
@@ -133,57 +131,57 @@ public void
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2079230716
Sorry for the delay on my end, I added a new commit to address all your
comments above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1543181369
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/GSFileSystemScenarioTest.java:
##
@@ -148,31 +147,31 @@ public void simpleWriteTest()
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2010479115
@ferenc-csaky Thank you for your insightful feedback and for directing me
towards the assertj decision. I updated my branch by rebasing it onto master
and incorporating the changes rela
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1511222835
##
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopFreeTests.java:
##
Review Comment:
Use AssertJ's `assertThatThrownBy
26 matches
Mail list logo
