[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4921 ---

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r149678385 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -210,15 +212,44 @@ public static ParameterTool fromSystemPr

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r149071909 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -210,15 +212,44 @@ public static ParameterTool fromSystemProperti

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148398599 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java --- @@ -83,82 +82,100 @@ public void add(Option option) thro

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148286896 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java --- @@ -83,82 +82,100 @@ public void add(Option option) throws Re

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148248128 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java --- @@ -454,124 +469,196 @@ public void testUnrequestedDouble

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148247868 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -560,9 +591,13 @@ protected Object clone() throws CloneNot

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148247266 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -210,15 +212,44 @@ public static ParameterTool fromSystemPr

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148240608 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -560,9 +591,13 @@ protected Object clone() throws CloneNotSuppor

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148241001 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java --- @@ -454,124 +469,196 @@ public void testUnrequestedDoubleWithMi

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-11-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4921#discussion_r148240611 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java --- @@ -210,15 +212,44 @@ public static ParameterTool fromSystemProperti

[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

2017-10-30 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4921 [FLINK-7943] Make ParameterTool thread safe ## What is the purpose of the change This commit changes the serialization of the ParameterTool such that only the data map is contained