Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r94921927
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/SetOperatorsValidationTest.scala
---
@@ -0,0 +1,119 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r94872463
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CalcITCase.scala
---
@@ -109,36 +110,6 @@ class CalcITCase(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r94872519
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SortValidationTest.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r94871520
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SortValidationTest.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93437996
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CalcValidationTest.scala
---
@@ -0,0 +1,111 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440307
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SortValidationTest.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440355
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CalcValidationTest.scala
---
@@ -0,0 +1,111 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93438060
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CastingPlanTest.scala
---
@@ -0,0 +1,130 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440071
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/AggregationsValidationTest.scala
---
@@ -0,0 +1,148 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440247
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/JoinPlanTest.scala
---
@@ -0,0 +1,283 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440286
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SetOperatorsValidationTest.scala
---
@@ -0,0 +1,128 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93438092
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/JoinPlanTest.scala
---
@@ -0,0 +1,283 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93438204
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SortValidationTest.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93438117
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/JoinValidationTest.scala
---
@@ -0,0 +1,197 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93438154
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SetOperatorsValidationTest.scala
---
@@ -0,0 +1,128 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93448930
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/AggregationsITCase.scala
---
@@ -400,5 +342,23 @@ class Aggregati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440266
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/JoinValidationTest.scala
---
@@ -0,0 +1,197 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93440220
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CastingPlanTest.scala
---
@@ -0,0 +1,130 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93439887
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/AggregationsPlanTest.scala
---
@@ -0,0 +1,350 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93437942
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/AggregationsValidationTest.scala
---
@@ -0,0 +1,148 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93436582
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CalcPlanTest.scala
---
@@ -0,0 +1,394 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93437895
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/AggregationsPlanTest.scala
---
@@ -0,0 +1,350 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93438663
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CalcITCase.scala
---
@@ -424,6 +425,19 @@ class CalcITCase(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2977#discussion_r93436751
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/CalcPlanTest.scala
---
@@ -0,0 +1,394 @@
+/*
+ * Licensed
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/2977
Flink 5084
I replace the Java Table API ITCases by tests that check that the parsing
step produces a valid logical plan.
Before I delete the ITCases, I have check there are UTCases in scala.
26 matches
Mail list logo
