Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2805
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r91306180
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
---
@@ -131,35 +132,30 @@ private void sendToTarget(T re
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90777420
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java
---
@@ -215,6 +189,31 @@ public Void answer(Invo
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90778003
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
@@ -421,22 +423,19 @@ private ResultPartitionWrite
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90777407
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java
---
@@ -215,6 +189,31 @@ public Void answer(Invo
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90777958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
---
@@ -131,35 +132,30 @@ private void sendToTarget(T reco
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r90777962
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
---
@@ -71,21 +68,26 @@ public void writeBuffer(B
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r87968119
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -586,7 +588,18 @@ private boolean performCheckpoin
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r87967007
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -586,7 +588,18 @@ private boolean performCheckpoi
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r87965585
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -586,7 +588,18 @@ private boolean performCheckpoin
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2805#discussion_r87900573
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -586,7 +588,18 @@ private boolean performCheckpoi
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/2805
Flink 5059
Only serialise events once in RecordWriter#broadcastEvent.
While adapting this, also clean up some related APIs which is now unused or
used similar patterns.
You can merge this pu
12 matches
Mail list logo
