[GitHub] flink pull request: fix pos assignment of instance

2015-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: fix pos assignment of instance

2015-11-19 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1345#issuecomment-158107692 Will merge this for 1.0.0 and 0.10.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: fix pos assignment of instance

2015-11-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1345#issuecomment-157783778 Thanks for spotting the error @fangmu. I assume that this error never occurred because we rarely start multiple instances on the same host. It is a crucial

[GitHub] flink pull request: fix pos assignment of instance

2015-11-11 Thread fangmu
Github user fangmu commented on the pull request: https://github.com/apache/flink/pull/1345#issuecomment-155810945 I found this when learning codes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: fix pos assignment of instance

2015-11-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1345#issuecomment-155735166 This looks like a bug you fixed. Do you have a case where this bug kicked in that you could add as a test? --- If your project is set up for it, you can reply to th

[GitHub] flink pull request: fix pos assignment of instance

2015-11-10 Thread fangmu
GitHub user fangmu opened a pull request: https://github.com/apache/flink/pull/1345 fix pos assignment of instance You can merge this pull request into a Git repository by running: $ git pull https://github.com/fangmu/flink master Alternatively you can review and apply these