Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1215#issuecomment-145482078
Impressive work, looks good!
Merging this means that we need to commit to reworking the `join()`
implementation very soon.
If that is the case, +1 f
Github user ktzoumas commented on the pull request:
https://github.com/apache/flink/pull/1215#issuecomment-145482079
+1 to merge. This will make the testing of the new API much easier
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user ktzoumas commented on a diff in the pull request:
https://github.com/apache/flink/pull/1215#discussion_r41125467
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -87,7 +207,7 @@
Github user ktzoumas commented on a diff in the pull request:
https://github.com/apache/flink/pull/1215#discussion_r41125422
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -24,49 +24,169
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1215#discussion_r41125469
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java
---
@@ -81,56
Github user ktzoumas commented on a diff in the pull request:
https://github.com/apache/flink/pull/1215#discussion_r41125302
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java
---
@@ -81,56
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1215#issuecomment-145254403
I updates this to also add Javadocs for the new windowing
semantics/internals.
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1215
Stream API Refactoring
This is a WIP of the refactoring. I still want to add Javadocs and a new
join operator based on tagged union that uses the new windowing operators.
You can merge this