[GitHub] flink pull request: Small cleanup on code after branch for 0.8 rel...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/302#issuecomment-69969666 I agree this should not be merged for 0.8.0 release. We should keep it in master for 0.9 and maybe included when we need 0.8.x rebase from master. --- If your project is

[GitHub] flink pull request: Small cleanup on code after branch for 0.8 rel...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/302#issuecomment-69968650 Good cleanups! The 0.8.0 release has a few release candidates out already and at this point I would suggest to fix what we find there, but not add any other co

[GitHub] flink pull request: Small cleanup on code after branch for 0.8 rel...

2015-01-12 Thread hsaputra
GitHub user hsaputra opened a pull request: https://github.com/apache/flink/pull/302 Small cleanup on code after branch for 0.8 release Small cleanup on code after branch for 0.8 release: -) Remove semicolons in Scala code for consistencies. -) Wrap some code in Java that is