Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-218967944
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-217804461
I'm running a last local test and then merging this. Thanks for the work!
ð
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216487812
There IRC Wikimedia channel is timing out and hence the reason for Wiki
test failures, nothing to do with this PR.
LGTM IMO
---
If your project is set up for i
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216466422
The build now fails consistently for the wikipedia connector? Could you
push another dummy commit to rerun travis tests. Let's see if it goes away.
---
If your project
Github user cowtowncoder commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216415361
@smarthi Updated as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216409045
ElasticSearch 2.x requires jackson >= 2.6.2, hence the Elastic 2.x
connector jackson version is set at 2.7.x. Locally, I changed the Jackson
version to be 2.7.x in the
Github user cowtowncoder commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216337481
@aljoscha @fhueske Nothing special, just thought I'd start with smallest
step, given that this is my first contribution here.
But given that 2.7.4 is out now, I
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216223474
@cowtowncoder do you see a reason for not upgrading all the way to 2.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216188894
Yes, I hope so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216167122
@fhueske jackson-databind is only used in the Table API to render the
explain output. We should be good to update to latest there as well, right?
---
If your project i
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1952#discussion_r61670156
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -55,11 +55,11 @@ under the License.
${elasticsearch.versio
GitHub user cowtowncoder opened a pull request:
https://github.com/apache/flink/pull/1952
Jackson version upgrade: default from 2.4.2 to 2.5.5, ES client to latest
2.7
Fix for [FLINK-3855] -- upgrade default Jackson version from 2.4.2 to 2.5.5
(last 2.5 patch); remove unnecessary e
13 matches
Mail list logo
