[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-02-03 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/351#issuecomment-72686769 Ah, I meant to suggest different error message to make sure we know either input format or type information is missing. I will send another PR to implement this.

[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-02-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/351#issuecomment-72629129 I tried to implement Henry's idea, but I noticed the error message is very specific to the site where it is created, since it refers to an alternate method of `DataSet

[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-02-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/351#issuecomment-72623931 I'll merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-02-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/351#issuecomment-72618284 Good idea, Henry, if we can make sure that the IllegalArgumentException is not thrown in any other cases. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-01-29 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/351#issuecomment-72162452 To reduce code duplication and tracing, we could just throw the exception inside createInput(InputFormat inputFormat, TypeInformation producedType) by wrapping IllegalArg

[GitHub] flink pull request: Improved exception for missing type of InputFo...

2015-01-29 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/351 Improved exception for missing type of InputFormat As per discussion on the dev mailing list. You can merge this pull request into a Git repository by running: $ git pull https://github.com/twal