Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2047#issuecomment-222640704
I would do one change here: Make the `isRunning` flag non transient, and
set it to true initially, rather than in open.
That can act as a safeguard against v
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2047#issuecomment-222532431
close() is called by all operators when the operator finishes without an
exception of canceling. Have a look at the AbstractUDFStream
Stop() is thought to be
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65093352
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13 @@ pu
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65093152
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13 @@ pu
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65087502
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65068847
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13 @@ p
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65068621
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13 @@ pu
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/2047#issuecomment-222344951
I started to add some NiFi integration tests which are presently lacking,
but realized that it would be better to have that as part of a different jira.
---
If your pro
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2047
FLINK-3405: Extend NiFiSource with interface StoppableFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
