Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-215480471
This PR can be closed. A `CsvTableSource` has been implemented with PR
#1939.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-206327407
Ah, I forgot, it was @jamescao who opened it... :sweat_smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-206318618
@aljoscha I don't have the permissions to close it ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-206227156
Ok, but I gather from you not closing this that you still plan to do the
work? :smile:
---
If your project is set up for it, you can reply to this email and have your
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-206214102
I think this PR has to be rewritten entirely to be in sync with the new
Table API and `TableDef`s which are defined here:
https://docs.google.com/document/d/1sITIShmJMGeg
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-205882687
@twalthr @fhueske @vasia Is this still valid with the recent changes in the
Table API?
---
If your project is set up for it, you can reply to this email and have your
r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-138887848
Hi @twalthr, can you give an update for the other Table API InputFormats?
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
Github user jamescao commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-127654532
@twalthr
Great! I will hold my work on this issue. I think FLINK-2167 will set a
good reference for other fromXXX issues.
---
If your project is set up for it, you
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-127529145
Hi all, I'm currently working on the HCatInputFormat (FLINK-2167) for the
Table API. I think I will complete it this week. That was why I wanted to
review the PR later as
Github user jamescao commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-127451006
It turns out that moving `TableEnvironment` to `org.apache.flink.api.table`
may not be a clean solution to this problem. the `toDataSet()` and
`toDataStream()` methods o
Github user jamescao commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-127090230
It seems that
[FLINK-2167](https://issues.apache.org/jira/browse/FLINK-2167?jql=project%20%3D%20FLINK%20AND%20resolution%20%3D%20Unresolved%20AND%20text%20~%20%22hcatalog
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-127048597
+1 to move it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-126624411
Maybe we could move the TableEnvironment to org.apache.flink.api.table to
make it clear that it can be used for both languages.
---
If your project is set up for it, yo
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-126621482
Just my opinion, `TableEnvironment` is located under
`org.apache.flink.api.java.table` because of unifying of Table API
implementation. But Table API is implemented on
Github user jamescao commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-126536010
Hi Chiwan
Thanks for your comment! I was new to this community and I am not very
familiar with the design conventions.
1. I was a little bit confused about t
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-126380793
Hi @jamescao, thanks for your contribution. I read this pull request and
have some comments about this.
First, Test cases are insufficient. There is no test ca
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-125137223
Hi @jamescao, thanks for the contribution. I will review your code soon.
I'm currently also writing a TableEnvironment `fromXXX()` method.
---
If your project is set up
GitHub user jamescao opened a pull request:
https://github.com/apache/flink/pull/939
FLINK-2166. Add fromCsvFile() method to TableEnvironment. A tuple based
CsvInputFormat, a pojo based CsvReader or a Parameterized tuple based
CsvReader is used to represent the row of the table's ty
19 matches
Mail list logo
