Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1078
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-170050950
Looks really good :-) Thanks for your contribution @daniel-pape. Will merge
it.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user daniel-pape commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-166991692
Thanks for the comment @tillrohrmann. Just pushed the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-158969810
Sorry for my late reply @daniel-pape. The PR looks really good. I had only
one minor comment. Once this is fixed, it's good to be merged.
---
If your project is se
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r45615952
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseVector.scala
---
@@ -85,6 +86,39 @@ case class SparseVector(
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r45615836
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r45615350
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user daniel-pape commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r40507078
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user daniel-pape commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r40507074
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseVector.scala
---
@@ -85,6 +85,34 @@ case class SparseVector(
}
Github user daniel-pape commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r40507071
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseVector.scala
---
@@ -85,6 +85,34 @@ case class SparseVector(
}
Github user daniel-pape commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r40507046
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user daniel-pape commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r40507042
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-139493422
Thank you very much @daniel-pape for you contribution. Looks really good. I
had only some minor comments.
---
If your project is set up for it, you can reply to th
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r39253106
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r39253000
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseVector.scala
---
@@ -85,6 +85,34 @@ case class SparseVector(
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r39252383
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseVector.scala
---
@@ -85,6 +85,34 @@ case class SparseVector(
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r39251962
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user daniel-pape commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-139376525
Will be fixed and I will also review what @chiwanpark suggested, though I
think .toArray was called with an intend (for comprehensions yield collections
of the same
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-138954598
Looks good to me except some minor issues (including things @rmetzger
said). But there is no JIRA issue covered this PR. We should create JIRA issue
first.
---
If y
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r39059950
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector(
}
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-138826497
Your build is failing due to scalastyle checks
```
[INFO]
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ flink-ml ---
[INFO] Failsafe repo
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-138825531
Thanks a lot for the pull request.
Sorry that nobody looked at it yet. It seems that all committers are
currently very busy. I'm sure somebody will give you soon fee
GitHub user daniel-pape opened a pull request:
https://github.com/apache/flink/pull/1078
FLINK-1737: Kronecker product
This is preparational work related to FLINK-1737: Adds an implementation of
outer/Kronecker product which can subsequently be used to compute the sample
covariance
23 matches
Mail list logo
