[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

2015-11-17 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1362#issuecomment-157342698 Looks good, will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

2015-11-17 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/pull/1362#issuecomment-157309957 @tillrohrmann this is the nitpick PR we talked about --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink pull request: Change the parameter 'numSample' in DataSetUti...

2015-11-16 Thread smarthi
GitHub user smarthi opened a pull request: https://github.com/apache/flink/pull/1362 Change the parameter 'numSample' in DataSetUtils.sampleWithSize() to … …'numSamples', and remove redundant Java 6 code You can merge this pull request into a Git repository by running: $ gi