Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/711
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/711#issuecomment-105562752
Thanks for the review @StephanEwen , that what I was suspecting =)
Will commence with merge ...
---
If your project is set up for it, you can reply to this email and
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/711#issuecomment-105502193
I think that one is on me. The Java convention is to have static final
fields uppercase (constants).
Scala does not follow that convention. So I wrote Scala code f
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/711#issuecomment-105418301
Thanks @rmetzger for the review. Will merge this EOD tomorrow if no
objection.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/711#issuecomment-104712456
CC @StephanEwen
I think that could be expressed via right name or additional comments
rather than using all caps.
---
If your project is set up for it, you ca
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/711#issuecomment-104703453
Change looks good, I'm not sure if there was any deeper meaning in the all
caps name.
Would be good if the authors of the code could let us know.
---
If your projec
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/711
Change FlinkMiniCluster#HOSTNAME to FlinkMiniCluster#hostname to match
naming convention.
The FlinkMiniCluster contain member variable called HOSTNAME which all
caps. The naming of al caps usually
