[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-04 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72857627 I think that this only happens for the primitive types. I think this is by design. If you want to inspect generic parameters, Scala forces you to use the Scal

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72752435 Nope, sorry, also have no Idea why this is happening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72741911 I looked into your issue. Scala has a very strange behavior at this point. I don't know why it converts `Int` to `Object`. The TypeExtractor gets `Tuple3` which results in

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72660810 I think that [this StackOverflow article explains my problem](http://stackoverflow.com/questions/11586944/how-to-obtain-the-raw-datatype-of-a-parameter-of-a-field-that-

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72660318 I would advocate to adding this one as well as a fallback option. I have a situation where I want to use KeySelector that might return Java TupleXX instances p

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72620298 I'll close it. I've filed a jira for the issue and assigned it to @twalthr: https://issues.apache.org/jira/browse/FLINK-1471 --- If your project is set up for it, yo

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72614564 So, this pull request can be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72316077 Cool, thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72315446 I can create a fix for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72315355 Do you want to fix it or should I do it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72315121 It's a bug in line 689. The input validation tries to get the generic parameters that are not available, in this case the validation should be skipped. --- If your proje

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72314532 Without the change, I'm getting the following error, even though my KeyExtractor implements ResultTypeQueryable: ```java Exception in thread "main" java.lang.Illeg

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-31 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72314389 getUnaryOperatorReturnType() does already call ResultTypeQueryable if available. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-01-30 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/354 Allow KeySelectors to implement ResultTypeQueryable You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink resulttypeqKS Alternatively