[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-139245906 Hi @PieterJanVanAeken, I think it is fine to just update the test file that your PR touches and port this one to the `collect()` approach. Then we don't need to wait

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-135360987 I'm inclined to the @tillrohrmann 's comment. I think that it is okay to call GraphAlgorithm based on Scala API in Java API and the user has the responsibility to ver

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-12575 I guess that all the tests should then be reworked as you've stated before merging this PR. I think it's fair enough to say that the developer of the algori

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-133328052 @tillrohrmann I rebased on the latest master, but the tests are based on older Java Gelly tests. They all need to be reworked then, since they all use the same

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132966338 I'm not a Gelly expert, but conceptually I don't think that it is wrong to call an algorithm which was developed with the Scala API from within the Java API. Otherw

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37514284 --- Diff: flink-staging/flink-gelly-scala/src/test/scala/org/apache/flink/graph/scala/test/operations/MapEdgesITCase.scala --- @@ -92,6 +92,30 @@ Multip

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37513671 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/GraphAlgorithm.scala --- @@ -0,0 +1,30 @@ +/* + * Licensed

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132502725 **EDIT:** I tried the approach above, and technically it works. But when I create a GraphAlgorithm[Long,Long,Long] in Scala, it does not work on a Java Graph[L

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132495162 Fixed the style issues. At this point in time, it is not possible to run Scala-based graph algorithms from inside the Java API. Do you think this woul

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132429945 Looks good. There are some code style issues. Please modify them. BTW, Is it possible to run graph algorithm implemented with Scala in Java? If yes, it would

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37376484 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/GraphAlgorithm.scala --- @@ -0,0 +1,30 @@ +/* + * Licensed t

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37376469 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -649,10 +650,13 @@ TypeInformation : ClassTag](jg

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1033#discussion_r37376477 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -649,10 +650,13 @@ TypeInformation : ClassTag](jg

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132249704 By the way, let me know if I need to create a JIRA for this first but it seemed overkill for such a trivial change. --- If your project is set up for it, you

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1033#issuecomment-132241973 Please wait a sec with this one. Something is off with my local changes vs my repo changes. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: Add Scala version of GraphAlgorithm

GitHub user PieterJanVanAeken opened a pull request: https://github.com/apache/flink/pull/1033 Add Scala version of GraphAlgorithm The Scala Gelly API already has a wrapper for running java-based GraphAlgorithms. It is needed for running pre-built algorithms such as the PageRankAlg