[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1391#issuecomment-159274087 LGTM. Thanks for your contribution @smarthi. Will be merging. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-22 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/pull/1391#issuecomment-158790920 @rmetzger good to merge now, travis builds are successful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1391#issuecomment-158779096 The tests of `master` on travis are green. Maybe your changes are side-effecting something with the table API? You could also try to rebase your changes to the current

[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-22 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/pull/1391#issuecomment-158778768 @rmetzger This is from the Table API which this PR does not touch, I can either withdraw the PR or we could trigger another travis build for this PR and see if the error

[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1391#issuecomment-158775699 According to travis, this PR is breaking the build ``` [ERROR] /home/travis/build/apache/flink/flink-staging/flink-table/src/main/scala/org/apache/flink/api/scal

[GitHub] flink pull request: [streaming-scala] Code cleanup: unused imports...

2015-11-21 Thread smarthi
GitHub user smarthi opened a pull request: https://github.com/apache/flink/pull/1391 [streaming-scala] Code cleanup: unused imports, fix javadocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/smarthi/flink master Alternatively