[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-103641540 I take it your update means you agreed with my suggestion :) I'll merge this one as well! --- If your project is set up for it, you can reply to this email and have you

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102684206 PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-15 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102376105 If you don't like the example string at the end, then we can go for sol (b) --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-15 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-102373199 Hi @andralungu, regarding `EdgeWithLongIdNullValueParser`: good catch, let's remove it then. As for the renaming, I would like the examples naming to be con

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-05-06 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/625#issuecomment-99499311 @vasia Don't forget to also have a look at this PR. It's rebased :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [gelly][Refactoring] Removed example string

2015-04-26 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/625 [gelly][Refactoring] Removed example string @vasia, Just FYI :), in example/utils we have a class EdgeWithLongIdNullValueParser that is never used. The examples that correspond