[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-21 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1260#issuecomment-149861741 I agree, it makes sense to add the documentation as a separate PR. I think here in the office, all of us are using IntelliJ by now. But I could try to get my old Ec

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-21 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/1260#issuecomment-149848186 @tillrohrmann The list of TODOs from the JIRA issue is referring concretely to IntelliJ. Is there some Eclipse user who can see what the corresponding actions for Ec

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-21 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/1260#issuecomment-149847793 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1260#issuecomment-149838480 Will merge this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1260#issuecomment-149623979 +1 looks good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1260#issuecomment-149567354 Looks good to me. +1 for merging. Maybe we could also add some documentation for how to change the Scala version with your favourite IDE as described by you in http

[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...

2015-10-15 Thread aalexandrov
GitHub user aalexandrov opened a pull request: https://github.com/apache/flink/pull/1260 [docs] Fix documentation for building Flink with Scala 2.11 or 2.10 This fixes some dead anchor links and aligns the text in "Build Flink for a specific Scala version" against the commands requi