[GitHub] flink pull request: [docs] Change doc layout

2015-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [docs] Change doc layout

2015-04-22 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-95174641 Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [docs] Change doc layout

2015-04-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-95117199 Addressed: - Move Flink on Tez under Setup, since programming a job is the same, deployment is different? => moved to setup - The "beta" badge is not separated clearly

[GitHub] flink pull request: [docs] Change doc layout

2015-04-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-94393362 Why did you remove the Disqus comments from the pages? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [docs] Change doc layout

2015-04-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/606#discussion_r28671427 --- Diff: docs/setup/local_setup.md --- @@ -20,11 +20,11 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request: [docs] Change doc layout

2015-04-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/606#discussion_r28671249 --- Diff: docs/setup/local_setup.md --- @@ -20,11 +20,11 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request: [docs] Change doc layout

2015-04-17 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-94047840 +1 Love it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] flink pull request: [docs] Change doc layout

2015-04-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-94044855 It looks much better. I'm +1 for merging it immediately like this. Once its merged, I would propose to make some minor changes: - The "beta" badge is not separate

[GitHub] flink pull request: [docs] Change doc layout

2015-04-17 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-94031487 I like the new docs layout :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] flink pull request: [docs] Change doc layout

2015-04-17 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93984370 Very difficult to visualize all the changes with screenshots but it takes a few seconds to build the website. From your Flink source directory: `git fetch https://gith

[GitHub] flink pull request: [docs] Change doc layout

2015-04-17 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93982293 Is there a way a preview version uploaded somewhere, or a screenshot, or do I need to build the docs myself? --- If your project is set up for it, you can reply to th

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93837926 This is one of the best project documentations that I have seen. Thanks a lot Ufuk for doing this! I would merge this as is. Few minor thoughts I had when skimmin

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93763019 :+1: Looks much much better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/606 [docs] Change doc layout This is not completely done yet, but should suffice to give a feeling of the new layout. I think this is a good improvement over our current state. - Changed layout (sim