Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56575375
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSinkITCase.jav
Github user zcox commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56574878
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSinkITCase.java
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56316199
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -0,0 +1,107 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1792#issuecomment-197245618
Looks good to merge @smarthi!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56308507
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -0,0 +1,107 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1792#issuecomment-196754905
Thank you for working on this Suneel!
I had some comments in the pull request.
Also, I think we need to update the documentation to refer to this
implementation
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56141103
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2/Elasticsearch2SinkITCase.j
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56141058
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/RequestIndexer.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140971
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/Elasticsearch2Sink.java
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140947
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -0,0 +1,113 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140915
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/Elasticsearch2Sink.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140677
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/RequestIndexer.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140658
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -0,0 +1,113 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56140261
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticSearch2SinkFunction.j
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1792#issuecomment-196751172
I don't think we necessarily need the "2" in the names; since it is a
module specific for ElasitSearch2 anyway.
---
If your project is set up for it, you can reply to th
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56139476
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticSearch2SinkFunction.j
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1792
[WIP] FLINK-3115: Update ElasticSearch connector to 2.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink ElasticSearch2
Alternativ
17 matches
Mail list logo
