Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-222161038
I was interested to see what happened here and a simple rebase and force
push corrects the problem.
Make sure local master is up-to-date
$ git checkout mas
Github user mbode commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-222155560
Sorry guys, botched the PR :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbode closed the pull request at:
https://github.com/apache/flink/pull/1966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-220395032
I think for now, we should add a `@Deprecated` annotation to the
`Histogram` and its related method on `RuntimeContext` and mention in the
comment that we encourage
Github user mbode commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-220277425
Hi Stephan, sounds good.
1. I wanted to avoid too much duplication, but I see your point.
2. Ok, throwing a new exception breaks the API. So should I just mark
`His
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-220275432
Please let me know what you think about these suggestions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-220275206
I like the addition. Two things, however, that I am not sure about:
1. The `Histogram` uses a `LongHistogram` internally, which results in a
lot of wrappin
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1966#discussion_r63847905
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
-
GitHub user mbode reopened a pull request:
https://github.com/apache/flink/pull/1966
[FLINK-3836] Add LongHistogram accumulator
New accumulator `LongHistogram`; the `Histogram` accumulator now throws an
`IllegalArgumentException` instead of letting the int overflow.
- [x]
Github user mbode closed the pull request at:
https://github.com/apache/flink/pull/1966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
GitHub user mbode opened a pull request:
https://github.com/apache/flink/pull/1966
[Flink-3836] Add LongHistogram accumulator
New accumulator `LongHistogram`; the `Histogram` accumulator now throws an
`IllegalArgumentException` instead of letting the int overflow.
- [x] Ge
11 matches
Mail list logo
