Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1556#issuecomment-177541447
I got it, as most of the work is done by code generation, current
DataSetProjectRule/DataSetFilterRule/DataSetCalRule implementation should be
ready. Most part of `
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1556#issuecomment-177517981
@ChengXiangLi The code generation will be similar to the old Table API. The
main difference is that the code generation already happens at the client side.
The generated
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1556#issuecomment-176894471
Thanks for the comments, i would create a new PR based on Fabian's work.
Besides, @twalthr , what's the scope of your code generation, previous Table
API code gen
Github user ChengXiangLi closed the pull request at:
https://github.com/apache/flink/pull/1556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1556#discussion_r51125883
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/sql/calcite/flinkFunction/ProjectFunction.java
---
@@ -0,0 +1,49 @@
+/*
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1556#issuecomment-176157407
As far as I know the `Expressions` are for the user-facing API only, right?
I think we won't need the `RexToExpr` class anymore, as I am currently writing
a rex to code
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1556
[Flink-3226] Implement project and filter translator.
This is just prototype implementation to translate Calcite Project and
Filter into Flink RelNode. It still miss several parts, which could
