Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/682
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104344423
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104245060
+1, can you do it @rmetzger ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104241003
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104231736
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104180508
I have some minor remarks which need some attention, otherwise good to
merge.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30782153
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -93,6
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30782105
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -93,6
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30782073
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -93,6
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104179112
+1 The change is good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-103457498
Done.
Remove changes in ExecutionConfig. Adopted JUnit test. Rebased on current
master. Travis is green.
---
If your project is set up for it, you can reply to this em
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30580847
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -543,6 +542,144 @@ public void disableAutoTypeRegistration() {
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-102780139
Changed LocalStreamEnvironment to TestStreamEnvironment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30469207
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -543,6 +542,144 @@ public void disableAutoTypeRegistration() {
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-102779406
Ok, I am not pushing until we get some more feedback then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30469078
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -543,6 +542,144 @@ public void disableAutoTypeRegistration() {
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-102776567
Thank you for the contribution.
I would like to wait for some more feedback from other committers before we
merge this.
---
If your project is set up for it, you ca
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-102773476
Thanks, nice fix. I added one little amend: used `TestStreamEnvironment`
instead of local. The former lets you force a given parallelism regardless of
the machine. It is
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/682
[Flink-1985] Streaming does not correctly forward ExecutionConfig to runtime
added ExecutionConfig serialization for streaming jobs
closes #1985
You can merge this pull request into a Git repositor
19 matches
Mail list logo
