[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2016-04-26 Thread markus-h
Github user markus-h commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-214833775 Sorry for not driving this further. I think this pull request is now way too outdated to have any chance of rebasing it to the current master, therefore I will close it.

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2016-04-26 Thread markus-h
Github user markus-h closed the pull request at: https://github.com/apache/flink/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-05-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-100996059 I had a look at the pull request and I like very much what it tries to do. The problem right now is that I can hardly say without investing a lot of time whet

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-05-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-99797733 Hey @markus-h, sorry for not reacting to your pull request (other changes also sometimes need a lot of time until they are merged) I think @StephanEwen would be the be

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-29 Thread markus-h
Github user markus-h commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-97328336 Is someone still interested in this change? Again it has been more then 3 weeks since opening this pull request and I fixed all comments that were given. Since I touch a

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-08 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-90865992 Have the latest commits fixed it? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-07 Thread markus-h
Github user markus-h commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-90694363 There seems to be a race condition somewhere in my code but I have trouble finding it since I can not reproduce it locally. I thought my last change would fix it but it d

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-05 Thread markus-h
Github user markus-h commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-89849730 Thanks for your comments! I will try to revert my formattings. I am used to doing STRG+F while programming that probably changed the formatting. I also got ri

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-05 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/570#issuecomment-89823498 Nice to see that you picked this up again. :-) I know from experience that it can be tricky to port the old RPC calls to Akka msgs, so kudos. ;-) - I actually agree wi

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-04 Thread markus-h
GitHub user markus-h opened a pull request: https://github.com/apache/flink/pull/570 [FLINK-951] Reworking of Iteration Synchronization, Accumulators and Aggregators Iteration synchronization through JobManager Unification of Accumulators and Aggregators (removal of former Aggre