Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/2014#issuecomment-220956186
Thanks for the review @yjshen!
Will address the comment and merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2014#discussion_r64207510
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -33,20 +33,32 @@ class D
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2014#discussion_r64160758
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
@@ -33,20 +33,32 @@ class Da
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/2014
[FLINK-3939] [tableAPI] Prevent translation of unsupported distinct
aggregates and grouping sets.
PR fixes `DataSetAggregateRule` to not translate `LogicalAggregate`
operators that include distinct
