[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-30 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2011#issuecomment-222535754 Nice! Once all tests for these new cases pass as well, I'd say, feel free to merge this! --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-30 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/2011#issuecomment-222452659 @StephanEwen I will add unit tests for your examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-26 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/2011#issuecomment-221864540 From my tests it does but I think it is something that should have a unit test --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2011#issuecomment-221288209 Does this also prevent infinite recursion on non transitive recursive types? Something like: ```java public class A { public B field; }

[GitHub] flink pull request: [FLINK-3922] [types] Infinite recursion on Typ...

2016-05-19 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2011 [FLINK-3922] [types] Infinite recursion on TypeExtractor - [x] General - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text") - The pull request addresses o