[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220642391 Merging...we need to fix the RocksDB issue afterwards. In the worst case, we'll comment out the relevant test cases for now. The test which seems to cause the segfaults is `

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220545613 The Travis builds here also segfault in all RocksDB tests. I'm assuming these test failed silently in the past since I can't make any connection to the test plugin changes.

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220388275 I get segfaults from RocksDB in my Travis tests: https://travis-ci.org/mxm/flink/builds/131412162 Let's see how the builds here go. All in all, looks ready to be me

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220321817 Thanks for looking into the problem and providing a detailed explanation @markreddy. I think we're good to go with the newest version of the Surefire plugin. I verified the

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread markreddy
Github user markreddy commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220307660 I took a look at the root issue of upgrading to 2.19.1. I'm able to reliably reproduce this issue on my laptop. When I bump the version I get the same as @til

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220289348 Thanks @mxm ! Eagerly looking forward to the results... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220284867 Also pushed a version to my local Travis branch with some deliberately failing tests and debug output to see if the above tests are executed correctly (and don't fail silent

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220276542 I just replaced Failsafe with Surefire. Also updated the version of Surefire in a separate commit to see if the classpath issues occur there as well (after all it's the same

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220272107 👍 and make sure that the tests were not silently failing with 2.17 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220271685 In the surefire JIRA, the "silently ignore exceptions" bug is tagged to affect 2.18, not 2.17, so it may be good. How about: - Checking if using surefi

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220270745 The question is whether this bug was introduced with version `2.18.1` or whether it was already there in version `2.17`. We originally bumped the version to `2.18`

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220269992 @aljoscha Yes, I think so too :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220269898 If we can't resolve issues with the Failsafe plugin, we could switch to using the Surefire plugin also for Integration tests. Actually, the only benefit of the Failsafe plug

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220269755 But maybe it only works since the exceptions are silently ignored and not forwarded? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220267821 Reverting back to version `2.17` it works again (at least the plugin does not complain about the `NoSuchMethodError`). --- If your project is set up for it, you ca

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-19 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220257496 I could reproduce it via maven on my machine. It is a bit odd since he complains that ``` org.apache.flink.runtime.util.ZooKeeperUtils.startCuratorFram

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220098334 Could you reproduce the problem on your laptop? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220087832 Couldn't find the problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220081808 Running the tests from within IntelliJ works fine without a problem. I guess it has something todo how failsafe `2.19` handles dependencies. --- If your project is

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220044747 Good fix! The failures went unnoticed before, I guess? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220035850 Tests fail in flink-runtime now. Seem to be class path related problems. ``` CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.org.apache.flink.runtime.che

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2003 [FLINK-3909] update Maven Failsafe version Failures during execution of the integration tests with the Maven Failsafe plugin were silently ignored on Travis with Maven version 3.2.5. The problem