Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219815351
No, names are OK.
Just thought `DataSetJob` / `DataStreamJob` would be more consistent with
API and documentation.
We can update the names later.
---
If your p
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219814739
Race condition ;-)
@fhueske I have locally merged this already. To me the names are good, I
would keep them unless you feel strongly about the names.
---
If yo
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219814341
Thanks for reworking the quickstart jobs @markreddy. Change look good to me.
I am not sure about the naming of the jobs. Should we use `DataSetJob`
instead of `BatchJ
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219814154
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219713912
I like the pull request! (You updated the docs, the PR describes the
changes).
+1 to merge
---
If your project is set up for it, you can reply to this email a
Github user markreddy commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-219230214
Thanks for the review @tzulitai I've pushed fixes for all your comments
:thumbsup:
---
If your project is set up for it, you can reply to this email and have your
rep
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62820828
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29 @@
*
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-218413341
Made comments on some rather trivial javadoc / comment related stuff,
overall the PR looks good!
I like how you've also made effort to tidy up some details in the or
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62818792
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29 @@
*
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62818171
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29 @@
*
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62817913
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29 @@
*
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62816955
--- Diff:
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/StreamingJob.scala
---
@@ -0,0 +1,69 @@
+package
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62816359
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29 @@
*
GitHub user markreddy opened a pull request:
https://github.com/apache/flink/pull/1982
[FLINK-3852] update the quickstart module to include a streaming skeleton
- Added skeleton StreamingJob
- Moved Job to BatchJob
- Commented out transformers for the mainClass setting with a
15 matches
Mail list logo
