Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1980
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220658718
Thanks for the reviews @vasia! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64049343
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2055,22 +2055,22 @@ vertex and edge in the output graph stores the
common group value and the number
### Ja
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220620841
Thanks for the update @greghogan. I left a few comments for improvements of
the docs. After these are addressed it should be good to merge.
---
If your project is set up
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64048955
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -43,11 +43,13 @@
import java.util.L
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64048499
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/JaccardIndex.java
---
@@ -54,73 +57,112 @@
public st
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64048412
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/JaccardIndex.java
---
@@ -40,9 +43,9 @@
/**
* Driver fo
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64048334
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2250,14 +2250,33 @@ graph.run(new TranslateVertexValues(new
LongValueAddOffset(vertexCount)));
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64047578
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2055,22 +2055,22 @@ vertex and edge in the output graph stores the
common group value and the number
### Ja
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220600881
@vasia all updates should be in place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r64037567
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/degree/annotate/TranslateEdgeDegreeToIntValue.java
---
@@ -0,0 +1,51 @@
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63956013
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licen
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63951105
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/JaccardIndex.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licens
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63901325
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/library/similarity/JaccardIndexTest.java
---
@@ -0,0 +1,136 @@
+/*
+ * L
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63899403
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/library/similarity/JaccardIndexTest.java
---
@@ -0,0 +1,136 @@
+/*
+ * Licen
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63898835
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/library/similarity/JaccardIndexTest.java
---
@@ -0,0 +1,136 @@
+/*
+ * L
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63896459
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/library/similarity/JaccardIndexTest.java
---
@@ -0,0 +1,136 @@
+/*
+ * Licen
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63895157
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63894471
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63894348
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63894239
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63894069
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63893564
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
vertex
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63893365
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
ver
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63893177
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/degree/annotate/TranslateEdgeDegreeToIntValue.java
---
@@ -0,0 +1,51 @@
+/*
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63892449
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/JaccardIndex.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed t
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63892035
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
ver
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63892061
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/JaccardIndex.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed t
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63891097
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
vertex
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63890887
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
vertex
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63890630
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
vertex
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1980#discussion_r63890500
--- Diff: docs/apis/batch/libs/gelly.md ---
@@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
vertex
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220122997
I figured. I forgot to mention that I was looking to reference the
JaccardIndex self-join in the discussion of FLINK-3910 but I can link into the
PR this time.
---
I
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220118204
Great, that's my plan :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220116075
Hi @vasia that would be great if you have time after 2044.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220103434
Hey @greghogan,
it's usually a good idea to have at least one person look at the code :)
Is this blocking some other feature? If not, I could take a look at this PR
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1980#issuecomment-220088196
Tests are passing ... will merge ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1980
[FLINK-3780] [gelly] Jaccard Similarity
The Jaccard Index measures the similarity between vertex neighborhoods.
Scores range from 0.0 (no common neighbors) to 1.0 (all neighbors are common).
You
38 matches
Mail list logo
