Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1853#issuecomment-209507866
Manually merged in 885d543be8a8c0d1acdffa0003e394347d5376ef
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/1853
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1853#discussion_r59518788
--- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user ZackPierce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1853#discussion_r59289246
--- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1853#issuecomment-208312455
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1853#issuecomment-206299884
+1.
I know of some other places where I've used Guava's Hasher or Cache, which
we can also remove in order to be able to remove our Guava dependency.
---
If your p
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1853#issuecomment-205811166
+1 for merging :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1853
[FLINK-3700] [core] Add 'Preconditions' utility class.
The functionality that Flink uses from Guava is super simple and limited.
We get a big dependency that has caused a lot of pain in the p
