Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65348898
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -100,6 +102,9 @@
*/
private JobID lastJobID;
+
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978
@rmetzger I've updated the pull request and would like to get your opinion
on it again. I've addressed all your comments. Specifically, I've removed all
Yarn code from the CliFrontend. I've clarif
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65349622
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run() {
Runtime.getRuntime()
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65348868
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -20,8 +20,6 @@
--- End diff --
Done.
---
If your projec
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-222480544
Thanks for your comments @EronWright. This the the first refactoring of the
client code of both cluster related and job submission related matters. It is a
very good suggest
Github user EronWright commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-85524
This PR dovetails nicely with the Mesos work and I'll be sure to build on
it. Here's a few suggestions to align it even further.
The problem of _managing_
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r64975479
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -393,7 +373,7 @@ protected AbstractFlinkYarnCluster dep
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219993662
Thanks for the review. I'll try to incorporate your suggestions. I'll ping
you again for a second look :)
---
If your project is set up for it, you can reply to this email
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63683193
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run() {
Runtime.getRuntime()
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219992759
Thank you for working on this!
The flink-client is pretty complicated and I like this pull request as it
is reducing the complexity.
Maybe (depending on the imp
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63682705
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -65,31 +73,25 @@
/**
* Encapsulates the functionality nec
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63681528
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run() {
Runtime.getRunt
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63681079
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -830,53 +797,30 @@ else if (result instanceof DisposeSavepointFailure) {
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219989249
> I tried the change on a cluster, but the YARN session is not deploying:
I also tried out the changes on a (local) yarn cluster and everything
worked. I have to loo
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63680659
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -100,6 +102,9 @@
*/
private JobID lastJobID;
+
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63680404
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -830,53 +797,30 @@ else if (result instanceof DisposeSavepointFailure)
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63680057
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -65,31 +73,25 @@
/**
* Encapsulates the functionality necessar
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219987643
Forgetting an argument leads to a NPE
```
robert@cdh544-master:~/flink/build-target$ ./bin/flink run -m yarn-cluster
./examples/batch/WordCount.jar
YARN cl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219986951
I tried the change on a cluster, but the YARN session is not deploying:
```
2016-05-18 10:25:12,181 INFO
org.apache.hadoop.yarn.client.ConfiguredRMFai
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219987024
After the shutdown, I got the following exception
```
2016-05-18 10:26:07,076 INFO org.apache.flink.yarn.ApplicationClient
- Disconnect fr
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63679526
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -100,6 +102,9 @@
*/
private JobID lastJobID;
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63678293
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -65,31 +73,25 @@
/**
* Encapsulates the functionality nec
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63677960
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -20,8 +20,6 @@
--- End diff --
You're right, these should
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63677456
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -20,8 +20,6 @@
--- End diff --
The CliFrontend still
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-218712827
One test run failed but it's unrelated to the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1978
[FLINK-3667] refactor client communication
This is mainly an effort to refactor the client side of the cluster
instantiation and communication. This pull request moves around many things
which were alr
26 matches
Mail list logo
