Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1862
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1862#issuecomment-208272375
Thanks, I will make the change and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1862#issuecomment-208266838
+1 to merge after resolving one last minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1862#discussion_r59181718
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/TranslationContext.scala
---
@@ -53,21 +55,26 @@ object TranslationConte
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1862#issuecomment-207761336
Thanks for the review @fhueske. I've addressed your comments :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1862#issuecomment-207438727
Thanks for the PR. I had a few minor comments but otherwise it looks really
good.
There are a few follow up issues, IMO:
- Check if we somehow can get aroun
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1862#discussion_r59025508
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/sql/test/JoinITCase.scala
---
@@ -0,0 +1,239 @@
+/*
+ * Licensed to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1862#discussion_r59025219
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/sql/test/AggregationsITCase.scala
---
@@ -0,0 +1,264 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1862#discussion_r59007631
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/AbstractTableEnvironment.scala
---
@@ -83,4 +84,17 @@ class AbstractTableEnvi
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1862#discussion_r59007483
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/AbstractTableEnvironment.scala
---
@@ -83,4 +84,17 @@ class AbstractTableEnvi
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1862#issuecomment-206986445
Awesome! Really cool to see that coming to Flink.
I played a bit around with it and it seems to work ;)
```java
Table table = tableEnv.fromDataSet(input)
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1862
[FLINK-3640] Add support for SQL in DataSet programs
This PR adds basic support for batch SQL queries embedded in Table API
programs.
In order to run a SQL query, a `DataSet` or `Table` needs to b
12 matches
Mail list logo
