[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

2016-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

2016-05-23 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2015#issuecomment-220956222 Will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

2016-05-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2015#issuecomment-220829100 Thanks for the PR @yjshen. The changes look good. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-3632][TableAPI]Clean up Table API excep...

2016-05-21 Thread yjshen
GitHub user yjshen opened a pull request: https://github.com/apache/flink/pull/2015 [FLINK-3632][TableAPI]Clean up Table API exceptions As suggested by @fhueske in https://github.com/apache/flink/pull/1958#discussion_r62680699, we should use `TableException` in the following cases: