Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-208716571
The error of CI build failure is not relevant with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-208313579
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-207442123
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-206656056
@zentol codes modified and rebase the new commit with previous one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1857#discussion_r58701096
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -777,7 +777,50 @@ public CsvReader readCsvFile(String filePath) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1857#discussion_r58701074
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -777,7 +777,50 @@ public CsvReader readCsvFile(String filePath) {
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-206355988
@zentol , PR updated. The scala environment determine the type with
`implicitly[TypeInformation[T]]` which is always the class `Object`. In the
case this issue mentio
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-206250467
@zentol Thanks a lot for review work. I will modify the codes base on your
advice!
---
If your project is set up for it, you can reply to this email and have your
re
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1857#issuecomment-206248345
Should this method also be added to the scala environment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1857#discussion_r58673800
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/SourceFunctionTest.java
---
@@ -44,6 +45,18 @@ public void fromElementsTest() thro
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1857#discussion_r58673374
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -780,6 +780,33 @@ public CsvReader readCsvFile(String filePath) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1857#discussion_r58673287
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -780,6 +780,33 @@ public CsvReader readCsvFile(String filePath) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1857#discussion_r58673148
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -673,6 +673,43 @@ public TimeCh
GitHub user gallenvara opened a pull request:
https://github.com/apache/flink/pull/1857
[FLINK-3444] env.fromElements relies on the first input element for
determining the DataSet/DataStream type
Add fromElements method with based class type to avoid the exception.
You can merge th
15 matches
Mail list logo
