Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1674#discussion_r53794490
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
SET bin=%~dp0
SET FLINK_ROOT_DIR=%bin%.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1674#discussion_r53791882
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
SET bin=%~dp0
SET FLINK_ROOT_DIR=%bi
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1674#issuecomment-187605508
Changes look good to me. Thanks for your contribution @zentol. Will merge
it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1674#discussion_r53573047
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
SET bin=%~dp0
SET FLINK_ROOT_DIR=%bin%.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1674#discussion_r53571627
--- Diff: flink-dist/src/main/flink-bin/bin/pyflink2.bat ---
@@ -22,4 +22,4 @@ setlocal EnableDelayedExpansion
SET bin=%~dp0
SET FLINK_ROOT_DIR=%bi
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1674#issuecomment-186149376
This PR adds "" around the flink path within python bat files, so that
paths containing spaces are treated as a single argument.
---
If your project is set up for it, yo
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1674
[FLINK-3416] [py] Support for spaces in flink path
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3416_py_win
Alternatively you ca
