[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1614#issuecomment-182035391 Ah, yes, now I see. I'll just burn this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/1614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1614#issuecomment-182025617 Shouldn't the current record remain valid if `hasNext()` returned true? I mean the user might be holding on to the object returned in `next`, and expect it to not be chan

[GitHub] flink pull request: [FLINK-3382] Improve clarity of object reuse i...

2016-02-09 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1614 [FLINK-3382] Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper You can merge this pull request into a Git repository by running: $ git pull https://github.com/gregho