Github user alkagin closed the pull request at:
https://github.com/apache/flink/pull/1660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user alkagin commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-189313813
No objections, sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-189310673
Overall this PR looks good now. I'll go through the documentation more in
detail when i unify the docs for this PR and #1640 when merging.
Furthermore, I'd like t
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53440225
--- Diff: flink-streaming-connectors/flink-connector-cassandra/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185745685
Ran it on Ubuntu, and even though there still is the
NotSerializableException, the build still passes. Quite odd.
I may have misinterpreted the results of tests t
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185711495
Full stack trace (on Windows, will try them on Linux later on)
```
---
T E S T S
-
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53300199
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r5324
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -0,
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53299825
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53299568
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -0,
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53298948
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0 +
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53298910
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -
Github user alkagin commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185652429
@zentol I am looking CassandraConnectorTest.batch to figure out the problem.
Other tests work fine if i run locally, how kind of problem they throw to
you?
---
If y
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53294081
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/ClusterConfigurator.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53291334
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/ClusterConfigurator.java
---
@@ -
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185597416
tried running the tests locally and they fail across the board.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185596124
Relevant test failure
```
Running org.apache.flink.connectors.cassandra.CassandraConnectorTest
org.apache.flink.api.common.NonSerializableUserCodeException
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53282958
--- Diff: flink-streaming-connectors/flink-connector-cassandra/pom.xml ---
@@ -0,0 +1,149 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185593098
There's quite a bit of inconsistent formatting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53282016
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0 +1,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281895
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0 +1,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281890
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0 +1,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281770
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/examples/WriteCassandraSink.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281534
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -0,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281448
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/BaseCassandraSink.java
---
@@ -0,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281258
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/CassandraMapperSink.java
---
@@ -
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281038
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/examples/WriteCassandraSink.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281044
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/examples/WriteBatch.java
---
@@ -0,0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53280971
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/ClusterConfigurator.java
---
@@ -
Github user cellvia commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185576114
bump. is this happening?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53244631
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -0
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185434970
Thank you for the contribution. I just scrolled over the code once and made
some comments. I think some further (small) changes are needed here and there.
---
If your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53241280
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0 +
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53241145
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/examples/WriteCassandraMapperSink.ja
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53240407
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@ -
GitHub user alkagin opened a pull request:
https://github.com/apache/flink/pull/1660
[FLINK-3311] Add a connector for streaming data into Cassandra
[FLINK-3311](https://issues.apache.org/jira/browse/FLINK-3311): this PR
adds OutputFormat and InputFormat, just for Tuples, for batch p
36 matches
Mail list logo
