Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-176188709
Thank for the contribution and review!
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-176157025
looks good. +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-176153352
Hello zentol,
I dont see any updates from your side. Can you kindly let me know if this
PR is good to be merged so that I can close the issue?
---
If your proje
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175810825
Hello zentol,
I have squashed all changes. Can you please merge now?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-17561
if you can revert the changes to the imports it's good to merge IMO.
you don't have to create a new PR. you can squash the commits if you wish,
otherwise I'll do
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1551#discussion_r50993131
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -19,10 +19,7 @@
package org.
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175653356
Hello zentol,
Can you check the code changes now? The changes look exactly similar to
what you suggest. Can you let me know if this can be merged? or do I provide
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175619319
In that case i would suggest the following:
- change the default values to TYPE_FORWARD_ONLY and CONCUR_READ_ONLY to be
in line with createStatement()
-allow the u
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175592466
Hello zentol,
To answer your initial question,
```
is there any way to check which createStatement method is supported? what
happens if you use the w
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175589833
Hello zentol,
I made changes according to your post. Kindly review now.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1551#discussion_r50955346
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -92,6 +94,15 @@ public void open(Input
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175486665
is there any way to check which createStatement method is supported? what
happens if you use the wrong statement?
---
If your project is set up for it, you can reply to
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1551
[FLINK-3292]Fix for Bug in flink-jdbc. Not all JDBC drivers supported
Hello,
Here is the fix for issue FLINK-3292. Kindly review & merge.
Thanks & regards,
Subhobrata
You can me
14 matches
Mail list logo
