Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-182779503
I think Robert has a good point.
The examples should follow the implementations of the other examples after
the rework in PR #1581.
---
If your project is set up f
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-175544829
I understand that argument, and I would be strongly against adding examples
for each connector.
The pull request is moving the example away from the Kafka proje
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-174964868
Not quite sure about adding examples for the connectors to the examples
project. If we do that for all connectors, it becomes heavily loaded with
dependencies.
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1533
[FLINK-3270] Add Kafka example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3270
Alternatively you can review and apply
